ext/sockets: Fix socket_set_option() validation error messages#22772
Merged
Conversation
Member
|
target PHP-8.5 |
LamentXU123
marked this pull request as draft
July 16, 2026 19:21
devnexen
approved these changes
Jul 16, 2026
Member
|
did you merge believing it s master ? |
Member
Author
|
No. I merge this through gh UI for convenience into 8.5 and add merge commits into master later ( usually 5 min ) |
LamentXU123
added a commit
that referenced
this pull request
Jul 16, 2026
* PHP-8.5: ext/sockets: Fix socket_set_option() validation error messages (#22772)
Member
|
can be risky but ok.. |
Member
Author
|
I'd argue this could be better. This at first marked the PR as merged on github so people can know this thing accepted without clicking into it. This also lower the risk of potential supply chain attacks since this make sure what actually does go into the codebase is the exact same thing in the PR (Ilija has the point before) |
Member
|
I meant more you gotta make sure you re the only one merging at that moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few incorrect socket_set_option() validation error messages.
to
and several other changes.